tools/libxl: cleanup one libxl__calloc() usage
authorTiejun Chen <tiejun.chen@intel.com>
Tue, 10 Mar 2015 06:28:16 +0000 (14:28 +0800)
committerIan Campbell <ian.campbell@citrix.com>
Wed, 11 Mar 2015 11:36:39 +0000 (11:36 +0000)
Its pointless because internally, libxl__calloc() would always
terminate program execution if failed,

libxl__calloc()
    |
    + void *ptr = calloc(nmemb, size);
    + if (!ptr) libxl__alloc_failed(CTX, __func__, nmemb, size);
                    |
                    + _exit(-1);

Signed-off-by: Tiejun Chen <tiejun.chen@intel.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
tools/libxl/libxl_dm.c

index 8599a6ab3465370c26c4d0d24e10c3a28a93be2e..cb006dfafa050d38e4bba6f16cd844fb26777f26 100644 (file)
@@ -1175,10 +1175,6 @@ static void spawn_stub_launch_dm(libxl__egc *egc,
         num_console++;
 
     console = libxl__calloc(gc, num_console, sizeof(libxl__device_console));
-    if (!console) {
-        ret = ERROR_NOMEM;
-        goto out;
-    }
 
     for (i = 0; i < num_console; i++) {
         libxl__device device;